Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FroyoLocationUpdateRequester does not contain an implementation for requestLocationUpdates() #10

Open
GoogleCodeExporter opened this issue Nov 12, 2015 · 1 comment
Assignees

Comments

@GoogleCodeExporter
Copy link

The FroyoLocationUpdateRequester does not contain an implementation for the 
requestLocationUpdates() method defined in the abstract base class 
LocationUpdateRequester.

Suggested fix:  pull the implementation for requestLocationUpdates() up from 
the child class "GingerbreadLocationUpdateRequester".

Additional suggestion:  Add a "removeUpdates(PendingIntent p)" to the class 
hierarchy, so that the requester (code that actually holds the PendingIntent) 
can signal to the location manager that it's no longer interested in location 
updates.  See attached files for implementation.  Implement similar for 
LegacyLocationUpdateRequester.

Original issue reported on code.google.com by daniel.m...@gmail.com on 28 Oct 2011 at 6:44

Attachments:

@GoogleCodeExporter
Copy link
Author

I disagree. The implementation in GingerbreadLocationUpdateRequester invokes a 
method that does not exist in Froyo.

I think the implementation for 
FroyoLocationUpdateRequester.requestLocationUpdates(long, long, Criteria, 
PendingIntent) should come from LegacyLastLocationFinder.

Original comment by cow...@bbs.darktech.org on 7 May 2012 at 2:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants