Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all methods working on peaksData use the chunk-wise processing #307

Open
jorainer opened this issue Nov 24, 2023 · 0 comments
Open

Ensure all methods working on peaksData use the chunk-wise processing #307

jorainer opened this issue Nov 24, 2023 · 0 comments
Assignees
@philouail

Comments

@jorainer
Copy link
Member

Chunk-wise processing (#304 ) on peaks data is built-in .peaksapply and should be enabled/used in a consistent way. While all methods do already use the same approach two don't:

  • containsMz
  • containsNeutralLoss

These should be refactored to use the same call as in ionCount or isCentroided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philouail philouail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorainer @philouail