Icon Size

[ghost]

I use Papirus theme and the icons appear too small. They look alright with TopIcons but I don't prefer that extension as it does not show any text attached to an indicator.

So, would you mind adding a setting for icon size? Or else please tell me where to modify the code?

[jhasse]

Add the line

icon_size += 8;

here: https://github.com/rgcjonas/gnome-shell-extension-appindicator/blob/master/appIndicator.js#L221

[harry-cpp]

Can you add settings panel to control icon size?

[jhasse]

I'll look into that, but not right now. PRs welcome :)

[ghost]

Thank you very much @jhasse

[owais]

This is still an issue on Ubuntu 17.10 stock install. I tested on an XPS 13 with HiDPI screen.

[JasonLG1979]

You shouldn't manually set the icon size, you should instead use the built in style classes.

[jhasse]

Do you mean CSS classes?

[JasonLG1979]

Do you mean CSS classes?

Yes

[JasonLG1979]

If you use the standard style classes you don't have to worry about the size of things for the most part.

[JasonLG1979]

You should already be getting the panel-button style class for free if/when you extend PanelMenu.Button for your indicator icons. You shouldn't need to manually set the icon size.

[owais]

Current look on XPS 13 HD (1920x1080) display. The 2nd and 3rd icons from left (insync and slack) are appindicator icons

@didrocks FYI

[owais]

OK. It looks much worse in real life. For some reason it becomes more clear in screenshots but IRL the icons hardly grab attention in unread state.

[JasonLG1979]

It also depends on how much padding is around the icon in the actual icon svg. If for example it's a 16x16 svg but the icon itself has 1px of padding all around it then the icon would actually be whatever % smaller. Not much you can do about that.

[LiamDawe]

Also here to note that on Ubuntu 17.10 with the ubuntu version of the extension included by default, that the icons are too small.

See this pic: https://imgur.com/a/YkSPr

Big space in between them (too much) and the icons seem to be scaled down too much?

[jhasse]

Steam icon looks fine though. Is Dropbox with XDG_CURRENT_DESKTOP=Unity?

I'll install Ubuntu 17.10 tonight and also test this.

[orschiro]

I have this problem with Telegram Desktop.

[jhasse]

I just tried on a fresh updated Ubuntu 17.10: Dropbox' and Telegram's icons are the correct size when started with XDG_CURRENT_DESKTOP=Unity, so I guess this is some bug in Qt?

[jhasse]

Okay I've found out that this has to do with #95.

Before:

After:

My simple solution would be to increase the icon size by 2 and keep the PR, which would look like this:

Opinions?

[LiamDawe]

That does look vastly better, but still, I think the space between the icons could be cut by around half not to waste so much space. Leaves more space for more extensions and indicators then too.

[jhasse]

I think the space between the icons could be cut by around half not to waste so much space. Leaves more space for more extensions and indicators then too.

Check out https://extensions.gnome.org/extension/355/status-area-horizontal-spacing/ for that :)

[harry-cpp]

@jhasse unrelated, but I don't know where else to ask you, will stuff like 33fcc8e ever get undo-d?

[orschiro]

@jhasse

With XDG_CURRENT_DESKTOP=Unity:

Without XDG_CURRENT_DESKTOP=Unity:

[orschiro]

Something got fixed here. Thanks so much!

[jhasse]

@cra0zy Not right now, since we're missing the manpower to maintain this. Thanks for the commit, I didn't know that existed :)

@orschiro Hm ... I didn't push a new version. I guess you're using Ubuntu's version? Judging from your screenshot it looks like Telegram is now using TopIcons Plus instead.

I've pushed the +2 fix and will upload a new version to extensions.gnome.org now. Please open a new issue for any issues that arise.

[orschiro]

@jhasse sorry, my bad. I think it still looks like this because I used [1].

[1] orschiro@x230:~$ XDG_CURRENT_DESKTOP=Unity Telegram/Telegram

[orschiro]

@jhasse I see this issue is being closed but the problem with Telegram persists.

Related: telegramdesktop/tdesktop#3968

[jhasse]

Are you using the latest version of this extension?

[orschiro]

@jhasse I assume so because I have all latest updates for Ubuntu 17.10 installed.

[jhasse]

@orschiro Unfortunately no, the Ubuntu version lacks the last two commits.

See https://github.com/ubuntu/gnome-shell-extension-appindicator/tree/ubuntu

[orschiro]

@jhasse thanks for addressing the issue! I guess we just need to wait for the update then?

[didrocks]

@orschiro Do you mind opening a bug on launchpad with a detail (step by step) test case again the gnome-shell-extension-appindicator package? I'm happy to SRU it then so that you get the last commit.

[orschiro]

@didrocks done [1]. Thanks for addressing this!

[1] https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-appindicator/+bug/1730406

[jhasse]

I've increased the icon size once more, should be 22px now. This should make them as large as with TopIcons. Please test the latest master version and share your opinions :)

[orschiro]

Thanks!

Will follow the instructions [1] to check out the new 22px size.

On a sidenote, if I change Top Icons Plus to 22px it somehow doesn't look right. See Hangouts.

[1] https://github.com/ubuntu/gnome-shell-extension-appindicator#installation

[Feichtmeier]

@jhasse currently using the version which comes preinstalled with ubuntu 18.04 beta 2 and the icons are 1 or 2 px too big now :| Sorry, I guess this could drive you mad:

[robfrawley]

The icons are way too large now... They outsize the core gnome icons by a factor of 33%, easily.

Sure, it would be nice for sizing to be configurable for those that want crazy sized icons, but the default should not be that. The vast majority of people want icons from this extension that are the same size as the network/audio/battery icons sitting right next to them, not larged than the system icons.

Making these icons larger than the system icons makes it visually obvious this is an extension: the default should appear visually identical to the sizing of the system icons so that it looks like this is a core-gnome-supported feature.

The best extensions fade away and blend into the gnome environment; the changes made as a result of this PR cause way oversized icons and make the icons originating from this extension appear to be out of place with the desktop environment design.

[jhasse]

The vast majority of people want icons from this extension that are the same size as the network/audio/battery icons sitting right next to them, not larged than the system icons.

You don't know that.

[JasonLG1979]

I know I've said this before but even if it's a matter of manually resizing an icon you should be able to extract the icon size currently being used by the other panel icons from the "system-status-icon" style class.

[harry-cpp]

You don't know that.

Thats... such a bad statement on your part @jhasse ...

[jhasse]

Why?

[JasonLG1979]

@cra0zy I would a agree with you that consistent icon size in the panel makes for a more seamless look and generally is just better design.

[linvain]

Had the same issue on Arch Linux (GNOME 3.30.2)

Adding icon_size += 4 to _init method in ~/.local/share/gnome-shell/extensions/appindicatorsupport\@rgcjonas.gmail.com/appIndicator.js solved this. The icons appear the same size as they are on Ubuntu 🎉

[Feichtmeier]

@jhasse the icons are still too big. The best would be if they would have the same size as the gnome status menu icons in the right corner