From fab0ad2da4be2a83a1f66c0035e44bc63a954c97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dalmo=20Mendon=C3=A7a?= Date: Thu, 30 Jan 2020 14:31:56 +1300 Subject: [PATCH 1/2] fixes issue #4 --- webpack.config.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/webpack.config.js b/webpack.config.js index c9714405..1476a46b 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -74,12 +74,16 @@ module.exports = { to: path.join(distRootPath, 'manifest.json'), toType: 'file', } - ]), + ],{ + copyUnmodified: true // resolve conflict with `CleanWebpackPlugin` + }), new webpack.DefinePlugin({ 'NODE_ENV': JSON.stringify(nodeEnv), 'WEB_BROWSER': JSON.stringify(webBrowser), }), extensionReloader, - new CleanWebpackPlugin(), + new CleanWebpackPlugin({ + // cleanStaleWebpackAssets: false, // another way to resolve conflict with `CopyWebpackPlugin` + }), ], } From 7d37729d7029058bb4a4cdbd30cacf87299f1d7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dalmo=20Mendon=C3=A7a?= Date: Fri, 31 Jan 2020 16:44:20 +1300 Subject: [PATCH 2/2] removed unused hack --- webpack.config.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/webpack.config.js b/webpack.config.js index 1476a46b..02c53b05 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -82,8 +82,6 @@ module.exports = { 'WEB_BROWSER': JSON.stringify(webBrowser), }), extensionReloader, - new CleanWebpackPlugin({ - // cleanStaleWebpackAssets: false, // another way to resolve conflict with `CopyWebpackPlugin` - }), + new CleanWebpackPlugin(), ], }