Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace duplicate files with a build script #135

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

hurrymaplelad
Copy link
Contributor

@hurrymaplelad hurrymaplelad commented Oct 23, 2022

Neat project! I'd like to contribute more. These changes should make that easier.

See README.md for new build and test instructions.

Committing copies of files like password_template.html complicates merging and rebase, which bit me while experimenting with the webcrypto branch.

I added a package.json files allowlist to keep the new build script from bloating the published package.

I verified the files that would be published with npm run build && npm package --dry-run:

=== Tarball Contents === 
npm notice 1.1kB  LICENSE               
npm notice 10.2kB README.md             
npm notice 47.9kB crypto-js.min.js      
npm notice 9.0kB  index.js              
npm notice 1.2kB  package.json          
npm notice 9.8kB  password_template.html

@@ -1,4 +1,6 @@
.idea
node_modules
cli/.staticrypt.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was redundant. .staticrypt.json matches subdirectories as well.

@robinmoisson
Copy link
Owner

Hey @hurrymaplelad - thanks for your PRs! That's all looking great. I've been bitten bitten by the duplicated files and been wanting to automate all of that for a while, and really like your approach here.

@robinmoisson robinmoisson merged commit 9bac93c into robinmoisson:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants