Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child injectors in CommandExecutor are not destroyed #174

Open
fljot opened this issue Feb 2, 2015 · 0 comments
Open

Child injectors in CommandExecutor are not destroyed #174

fljot opened this issue Feb 2, 2015 · 0 comments

Comments

@fljot
Copy link

fljot commented Feb 2, 2015

https://github.com/robotlegs/robotlegs-framework/blob/master/src/robotlegs/bender/extensions/commandCenter/impl/CommandExecutor.as#L48

Here you create child injector (which is nice, because you can define custom mappings in the "scope" of command execution), but it's not destroyed anywhere. Maybe it would be even better to create child injector in executeCommands() and call childInjector.tearDown() in the end of this method? Or some disposal method for CommandExecutor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant