Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing new user experience to import from Chrome (PyPI not up to date) #211

Closed
MadLittleMods opened this issue Feb 12, 2024 · 4 comments

Comments

@MadLittleMods
Copy link

MadLittleMods commented Feb 12, 2024

The latest published version on PyPI is pass-import@3.4 from 2022-12-10. But there have been fixes for Chrome since then which means it's impossible import from chrome -> pass when installing from PyPI.

Reproduction instructions

Trying to use pimport to import from chrome to pass as indicated by the readme:

$ poetry init
$ poetry add pyaml
$ poetry add pass-import
$ poetry shell
# ❌ Doesn't work
$ pimport pass "/home/eric/Downloads/Chrome Passwords.csv" --out ~/.password-store
 [x] Error: Unable to detect the manager. Please try with: pimport <manager> /home/eric/Downloads/Chrome Passwords.csv

# ❌ Doesn't work
$ pimport pass chrome "/home/eric/Downloads/Chrome Passwords.csv" --out ~/.password-store
  w
 [x] Error: /home/eric/Downloads/Chrome Passwords.csv is not a valid exported chrome file.

Additionally, #210 also complicates the problem if you're trying to use a path like ~/Downloads/Chrome Passwords.csv.

Workaround

Build it from source:

$ git clone git@github.com:roddhjav/pass-import.git
$ cd pass-import
$ poetry init
$ poetry add pyaml
$ poetry add zxcvbn
$ poetry add requests
$ echo -e "\n\n[tool.poetry.scripts]\npimport = \"pass_import.__main__:main\"" >> pyproject.toml

$ poetry run pimport pass "/home/eric/Downloads/Chrome Passwords.csv" --out ~/.password-store --dry-run
[...]
Passwords exported: 1015
[...]
@MadLittleMods MadLittleMods changed the title Confusing new user experience (PyPI not up to date) Confusing new user experience to import from Chrome (PyPI not up to date) Feb 12, 2024
@roddhjav
Copy link
Owner

Yes... I need to make a new release and to polish a bit the packaging... I also need to find time for it. That should come soon...

@MadLittleMods
Copy link
Author

No rush and sorry @roddhjav. I'm seeing how this is probably more of a bother now. Given the drive-by nature of needing to import once, I was trying to eliminate some of the immediate friction for future onlookers. And given one of of the issues being completely my fault, just adding some noise.

Feel free to close as people can still find and reference the info. Appreciate your responses!

@Sturmfahrt
Copy link

i am having a similar issue. for example when i use $ pass import chrome passwords.csv here is a screen shot with the output.
20240220_19h14m47s_grim
i am able to replicate the issue by doing the same thing with `pimport' like how @MadLittleMods did.

@roddhjav
Copy link
Owner

All of this should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants