Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much cleaning #31

Closed
Sthing opened this issue Mar 2, 2018 · 2 comments
Closed

Too much cleaning #31

Sthing opened this issue Mar 2, 2018 · 2 comments

Comments

@Sthing
Copy link
Contributor

Sthing commented Mar 2, 2018

Hi Alex.
In the PasswordManager method satanize you have this line:

self._clean_protocol(entry, 'url')

I do not think the URL should be cleaned like that.
I understand you use _clean_protocol() on the title because it is always used in a path name, and only for that.
But the url-property is primarily a piece of information, and we loose information if we just delete the protocol-prefix.

I propose that the _clean_protocol() method is retired and the funtionality moved to _create_path().

I would be happy to create a PR, but wanted to get your thoughts here first.

Best regards,
Søren Thing

@roddhjav
Copy link
Owner

roddhjav commented Mar 2, 2018

Hi Søren,
You are right, the protocol cleaning in 'url' is not needed. As you proposed yourself, I am waiting for your PR. Just note, you cannot add this to _create_path because this function does not change the title.

@Sthing
Copy link
Contributor Author

Sthing commented Mar 3, 2018

Fixed by #33

@Sthing Sthing closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants