Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded minSdkVersion causes build failure when building for Detox #177

Open
daankennes opened this issue Aug 2, 2023 · 1 comment
Open

Comments

@daankennes
Copy link

Hi,

Thank you for your work on this project.

I'd like to address a concern regarding the usage of Rollbar-react-native. It appears that the library does not adhere to the best practice of passing through minSdkVersion from the project's build.gradle file. While there might be valid reasons for this decision (unknown to me), it is causing difficulties when using Detox. The build process fails when the minSdkVersion specified in the Rollbar-react-native library is lower than the one indicated in the project's build.gradle file.

To address this issue, I've resorted to using patch-package as a temporary fix. However, this solution is clearly far from ideal.

See this (old but still accurate) issue on GitHub.

Thank you once again,
Daan

@waltjones
Copy link
Contributor

The latest release drops the minSdkVersion to 16 (from 19), matching the current value in the rollbar-android dependency. This isn't a final solution, but hopefully helps some people.

https://github.com/rollbar/rollbar-react-native/releases/tag/v1.0.0-beta.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants