From bd2031dcf354a2345d799f4f0cfaf3647b6e6b88 Mon Sep 17 00:00:00 2001 From: Walt Jones Date: Fri, 28 Feb 2020 12:38:10 -0800 Subject: [PATCH 1/2] test: test ignoredMessages with regex including escaped literal --- test/predicates.test.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/predicates.test.js b/test/predicates.test.js index dac898d71..46b6a2304 100644 --- a/test/predicates.test.js +++ b/test/predicates.test.js @@ -377,6 +377,19 @@ describe('messageIsIgnored', function() { }; expect(p.messageIsIgnored(logger)(item, settings)).to.not.be.ok(); }); + it('false if ignoredMessages regex match', function() { + var item = { + level: 'critical', + body: { + message: {body: '{"data":{"messages":[{"message":"Unauthorized"}]}}'} + } + }; + var settings = { + reportLevel: 'debug', + ignoredMessages: ['{"data":{"messages":\\['] + }; + expect(p.messageIsIgnored(logger)(item, settings)).to.not.be.ok(); + }); it('true if both trace and body message but ignoredMessages only match body', function() { var item = { level: 'critical', From bf65a865a613851b55e0496afca11eeb214740b8 Mon Sep 17 00:00:00 2001 From: Walt Jones Date: Fri, 28 Feb 2020 13:28:32 -0800 Subject: [PATCH 2/2] test: add a couple more regex tests for ignoredMessages --- test/predicates.test.js | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/test/predicates.test.js b/test/predicates.test.js index 46b6a2304..e3b684402 100644 --- a/test/predicates.test.js +++ b/test/predicates.test.js @@ -378,6 +378,19 @@ describe('messageIsIgnored', function() { expect(p.messageIsIgnored(logger)(item, settings)).to.not.be.ok(); }); it('false if ignoredMessages regex match', function() { + var item = { + level: 'critical', + body: { + message: {body: 'This is an ignored message'} + } + }; + var settings = { + reportLevel: 'debug', + ignoredMessages: ['^This is an .{7} message$'] + }; + expect(p.messageIsIgnored(logger)(item, settings)).to.not.be.ok(); + }); + it('false if ignoredMessages literal match', function() { var item = { level: 'critical', body: { @@ -390,6 +403,19 @@ describe('messageIsIgnored', function() { }; expect(p.messageIsIgnored(logger)(item, settings)).to.not.be.ok(); }); + it('false if ignoredMessages more literal regex matches', function() { + var item = { + level: 'critical', + body: { + message: {body: 'Match these characters: (*+?)'} + } + }; + var settings = { + reportLevel: 'debug', + ignoredMessages: ['\\(\\*\\+\\?\\)'] + }; + expect(p.messageIsIgnored(logger)(item, settings)).to.not.be.ok(); + }); it('true if both trace and body message but ignoredMessages only match body', function() { var item = { level: 'critical',