We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LambdaHandler
Exported LambdaHandler type allows only sync functions even though AWS also supports async lambdas:
rollbar.js/index.d.ts
Line 35 in bf9a2ef
Rollbar's internal logic also seems to support both sync and async:
rollbar.js/src/server/rollbar.js
Line 284 in 63c2f64
but due to the incorrect type declaration linting and/or building of a project can fail.
Possibly Rollbar could use https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/handler.d.ts types for consistency with aws-lambda package.
The text was updated successfully, but these errors were encountered:
waltjones
Successfully merging a pull request may close this issue.
Exported
LambdaHandler
type allows only sync functions even though AWS also supports async lambdas:rollbar.js/index.d.ts
Line 35 in bf9a2ef
Rollbar's internal logic also seems to support both sync and async:
rollbar.js/src/server/rollbar.js
Line 284 in 63c2f64
but due to the incorrect type declaration linting and/or building of a project can fail.
Possibly Rollbar could use https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/handler.d.ts types for consistency with aws-lambda package.
The text was updated successfully, but these errors were encountered: