Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deconflicting for symbols of nested scopes #188

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feat: deconflicting for symbols of nested scopes #188

merged 3 commits into from
Nov 7, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 7, 2023 •
edited
Loading

Description

Closes #58.

Test Plan

Some test cases are failed and ignored, which are tracked in #190.

@hyf0
Copy link
Member Author

hyf0 commented Nov 7, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@hyf0 hyf0 mentioned this pull request Nov 7, 2023
Merged
@hyf0 hyf0 requested a review from underfin November 7, 2023 10:19
@hyf0 hyf0 mentioned this pull request Nov 7, 2023
Closed
5 tasks
Base automatically changed from 11-07-test_add_basic_deconflict_test to main November 7, 2023 10:35
@hyf0 hyf0 force-pushed the 11-07-feat_deconflicting_for_symbols_of_nested_scopes branch from 4c0b6bf to 9da2e9d Compare November 7, 2023 10:37
@hyf0 hyf0 merged commit 42a2421 into main Nov 7, 2023
5 checks passed
@hyf0 hyf0 deleted the 11-07-feat_deconflicting_for_symbols_of_nested_scopes branch November 7, 2023 11:45
@underfin
Copy link
Contributor

underfin commented Nov 7, 2023

Esbuild do this with parallel, https://github.com/evanw/esbuild/blob/main/internal/linker/linker.go#L5481. I think we also follow esbuild.

@underfin
Copy link
Contributor

underfin commented Nov 7, 2023

!bench

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Benchmark Results

group                            baseline                               pr
-----                            --------                               --
rolldown benchmark/threejs       1.00     15.3±0.19ms        ? ?/sec    1.04     15.9±0.73ms        ? ?/sec
rolldown benchmark/threejs10x    1.05   169.5±10.23ms        ? ?/sec    1.00    160.7±7.13ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request Nov 7, 2023
Closed
hyf0 added a commit that referenced this pull request Nov 9, 2023
@hyf0
test(rollup): enable tests failed in #188
3a40460
hyf0 added a commit that referenced this pull request Nov 9, 2023
@hyf0
test(rollup): enable tests failed in #188
89d722e
hyf0 added a commit that referenced this pull request Nov 9, 2023
@hyf0
test(rollup): enable partial tests failed in #188 (#196)
4856b9b 
* test(rollup): enable tests failed in #188

* Ignore some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

symbol deconflicting for nested scopes
2 participants
@hyf0 @underfin