In Spree 2.2 adding Product Sale Prices adds the price twice

[berkes]

When adding product sale prices at e.g. http://0.0.0.0:3000/admin/products/ruby-on-rails-mug/sale_prices, prices get added twice.

It is not some JS error adding a row double, the entry is added twice to the Database. I can see it afterwards in the DB and the logs list two times the query that inserts a new sales price.

I am not sure what triggers this, but I assume some hook or trigger is called twice.

[ronzalo]

When sale price is added on backend, is for all currencies and for all variants. I'll add some test for this behavior.

[berkes]

It seems to be an issue with the new Spree::Price#sale_price= setter, which adds a price. And is (accidentally) called from def new_sale, where a variable is set sale_price = ....

Fixing that, changes the behaviour, but does not solve it. I am digging deeper.

[berkes]

Scratch that. It is indeed a case where I have two Prices on a variant, one in USD and one in EUR.

I assume this is by design then.