Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On edit of replica pool manifest, operator should resize pool accordingly #989

Closed
ftab opened this issue Sep 18, 2017 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@ftab
Copy link
Contributor

ftab commented Sep 18, 2017

From discussion on slack

Steps:

  1. kubectl edit -n rook pool replicapool
  2. Change spec\replication\size parameter to something else, say 3

Expected result:
It does the ceph osd pool set replicapool size 3 for you

@galexrt galexrt self-assigned this Sep 18, 2017
@travisn
Copy link
Member

travisn commented Sep 18, 2017

note that the size can only be changed for pools that are already configured for replication. If you have an erasure-coded pool, you won't be able to change it to a replicated pool.

@kokhang
Copy link
Member

kokhang commented Sep 18, 2017

In K8S 1.8, CRDs have validation we can leverage for this. kubernetes/kubernetes#47263

@galexrt
Copy link
Member

galexrt commented Sep 19, 2017

@kokhang Are you sure we already want to use this feature? The docs read: This feature is alpha in v1.8 and may change in backward incompatible ways.. See the PR
for the validation docs here: kubernetes/website#5290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants