Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with third party themes? #19

Open
brihadeesh opened this issue Oct 13, 2020 · 6 comments
Open

Compatibility with third party themes? #19

brihadeesh opened this issue Oct 13, 2020 · 6 comments

Comments

@brihadeesh
Copy link

How easy (or hard) would using a third party colour theme with this setup, i.e. without the default emacs modeline and other stuff? I've tried using (for example's sake) the modus-operandi theme and a blank bar appears where the default modeline would have been. I'm somewhat new to emacs and elisp so please bear with me if this is a really stupid question for me to ask :)

@rougier
Copy link
Owner

rougier commented Oct 13, 2020

This would require to split the current theme into layout part and color part. If you're only interested in the header-line, you can probably extract it from the source and put the code in your .emacs file.

@brihadeesh
Copy link
Author

Well, I'm kinda hooked to pretty much all of the layout features! Would this be a feature you'd like to have as part of this project?

@rougier
Copy link
Owner

rougier commented Oct 14, 2020

I'm not sure how to do that. I suspect modus-operand set the modeline to fit his theme and there's not much we can do. Do you know if there's an option to leave the modeline untouched in modus?

@brihadeesh
Copy link
Author

I'll have to take a look at their code. I have a feeling though that this might require commenting out entire regions of the themes' code and run elegant-emacs after loading the theme. Will check and get back shortly.

@terlar
Copy link

terlar commented Oct 14, 2020

I think you are on to the right path, splitting the theme into several parts should work, then you can apply in a certain order.

  • ui (mode line/fringe/etc)
  • typography
  • content (I guess this is where the color config could happen)

Then you would apply all these themes and the desired color-scheme. I think you would have to experiment a bit though to find out what should live where.

Personally I have a theme that splits typography and color-scheme which works well.

If this is the case you would load in order of priority typography, ui, "external color-scheme", content

@brihadeesh
Copy link
Author

@terlar thanks, this makes sense. I'm just a little daunted about implementing these changes considering my near zero experience with elisp. I think Nicolas has already split some of the theming elements into separate files. Now I guess the UI chunk (i.e. elegant.el) needs to be split into the typography and UI parts and made compatible with other themes as well? I've been working with a macro that @ltmhs made for "colourless" themes and I believe I could borrow bits of that. Will fool around a bit before getting back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants