Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a delete/remove icon in Sorted button chip #1479

Closed
janvi01 opened this issue Nov 10, 2023 · 3 comments
Closed

Add a delete/remove icon in Sorted button chip #1479

janvi01 opened this issue Nov 10, 2023 · 3 comments

Comments

@janvi01
Copy link
Contributor

janvi01 commented Nov 10, 2023

Is your feature request related to a problem? Please describe.
While applying sorting in columns, a sorting chip/ button appears on the top and if a user wants to remove the sorting, the chip has to be clicked first and then delete.

Describe the solution you'd like
Add a delete icon beside sorted just as we have for the filter button to enhance user experience.

Filter button with delete icon -

Screenshot 2023-11-10 at 12 01 39 PM

Sorted button -

Screenshot 2023-11-10 at 12 02 00 PM
@nikhilgupta58
Copy link

I am picking this issue.

@nikhilgupta58
Copy link

After careful consideration and reviewing the existing functionality, it seems that we already have robust options for users to dis-select sorting:

  1. Delete CTA Beside Every Sorting: A delete CTA is conveniently placed beside each sorting option for quick removal.

  2. Clicking Sort Button Again: Users can also disable sorting by clicking the same sort button they used to enable it initially.

Given these accessible and intuitive options, it appears that introducing an additional cross (delete) CTA might be redundant and could potentially clutter the user interface.

Please refer the attachment!!

cc @Chadha93

Screen.Recording.2023-12-27.at.10.16.06.PM.mov

@Chadha93
Copy link
Member

Chadha93 commented Jan 9, 2024

After careful consideration and reviewing the existing functionality, it seems that we already have robust options for users to dis-select sorting:

  1. Delete CTA Beside Every Sorting: A delete CTA is conveniently placed beside each sorting option for quick removal.
  2. Clicking Sort Button Again: Users can also disable sorting by clicking the same sort button they used to enable it initially.

Given these accessible and intuitive options, it appears that introducing an additional cross (delete) CTA might be redundant and could potentially clutter the user interface.

Please refer the attachment!!

cc @Chadha93

Screen.Recording.2023-12-27.at.10.16.06.PM.mov

As the sorting chip servers both propose, to update the sort and column with deletion, the current UX is correct. Closing this issue.

@Chadha93 Chadha93 closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants