Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed paste on text field error #1524

Closed
wants to merge 3 commits into from

Conversation

anikdhabal
Copy link

@anikdhabal anikdhabal commented Jan 20, 2024

Fixes #1523
/claim #1523

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 4:39pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2024 4:39pm

Copy link

vercel bot commented Jan 20, 2024

@anikdhabal is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@anikdhabal anikdhabal changed the title fix: issue #1523 fix: fix paste text field error Jan 20, 2024
@anikdhabal anikdhabal changed the title fix: fix paste text field error fix: fixed paste on text field error Jan 20, 2024
@harinij
Copy link
Member

harinij commented Jan 20, 2024

Thanks @anikdhabal for the PR - can you share a before and after video to show it working plus showing if paste works fine in other fields as well.

@harinij harinij requested a review from bofeiw January 20, 2024 05:45
@anikdhabal
Copy link
Author

Thanks @anikdhabal for the PR - can you share a before and after video to show it working plus showing if paste works fine in other fields as well.

Yeah, let me share it quickly.

Copy link
Contributor

@bofeiw bofeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not resolve the issues described in the updated issue description, please update.

@anikdhabal
Copy link
Author

anikdhabal commented Jan 22, 2024

Primay.rowy-5e51f.Rowy.dev.and.10.more.pages.-.Personal.-.Microsoft_.Edge.2024-01-22.20-48-03.mp4

It's working fine now. I've attached the result.

Copy link
Contributor

@bofeiw bofeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anikdhabal issue 1 (pasting outside array subtable) is resolved, however issue 2 (pasting into cells into array subtable) persists, please take a look.

Pasting into a short text will throw an error:
Screenshot 2024-01-26 at 07 16 33

Pasting into a number will overwrite the whole array subtable field and crash the page:
Screenshot 2024-01-26 at 07 16 42
Screenshot 2024-01-26 at 07 18 02

Please check and make sure pasting into all supported fields inside array subtable works.

@anikdhabal
Copy link
Author

anikdhabal commented Jan 27, 2024

I've updated the code, and now both issues are resolved.

@bofeiw
Copy link
Contributor

bofeiw commented Feb 7, 2024

Upon testing, issue 2 still persists.
Closing this as fixed in #1536

@bofeiw bofeiw closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: copy/paste on Array Subtable filed gives an incorrect error
3 participants