Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on subtable field results in redirection of the URL, remove it to fix nav issue #634

Closed
harinij opened this issue Feb 3, 2022 · 1 comment · Fixed by #685
Closed
Assignees
Labels
bug Something isn't working

Comments

@harinij
Copy link
Member

harinij commented Feb 3, 2022

Describe the bug
Currently, the links to subtable end with the URL "?parentLabel=" which seems to redirect to a URL ending with "?rowRef=". This causes issue when trying to navigate back with the back button, as instead of going back to the main table it goes to the original URL.

To Reproduce

  1. Go to a table with a subtable (example:All fields demo table)
  2. Click on a subtable value (notice how the URL redirects from "?parentLabel=" to "?rowRef=" at the end)
  3. Click the back button in your browser
  4. This will not take you to the main table as expected, you have to click the back button again to do so.

Expected behavior
Is there a reason for this redirection in URL to exist? if not it would be best to remove it.

@harinij harinij added the bug Something isn't working label Feb 3, 2022
@notsidney notsidney self-assigned this Feb 9, 2022
@notsidney
Copy link
Contributor

rowRef is used to make the URL link to the specific row that’s selected. parentLabel is used to display a label for the parent document of the sub-collection you’re viewing.

It looks like the code written for both overwrites the entire URL query string instead of modifying just one part of the query string. This should be migrated to Jotai’s atomWithHash

@notsidney notsidney linked a pull request Jun 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants