Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergerepo_c does not implement comps merging #301

Open
ignatenkobrain opened this issue Dec 31, 2021 · 2 comments
Open

mergerepo_c does not implement comps merging #301

ignatenkobrain opened this issue Dec 31, 2021 · 2 comments

Comments

@ignatenkobrain
Copy link

Very simple mergerepo_c --repo http://mirror.stream.centos.org/9-stream/BaseOS/x86_64/os/ --repo http://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/ -o tmp -v can reproduce this issue.

…
type group added to list from path: http://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/repodata/2bde0d29ee40944dcbf89c734172ecc96c2bff766977132e7d86dbcf1fdf7663-comps-AppStream.x86_64.xml 
…
15:37:27: cr_download: Successfully downloaded: /tmp/createrepo_c_tmp_repo_M6lQkn/repodata/2bde0d29ee40944dcbf89c734172ecc96c2bff766977132e7d86dbcf1fdf7663-comps-AppStream.x86_64.xml
…
type group added to list from path: /tmp/createrepo_c_tmp_repo_M6lQkn/repodata/2bde0d29ee40944dcbf89c734172ecc96c2bff766977132e7d86dbcf1fdf7663-comps-AppStream.x86_64.xml 
…
type group added to list from path: http://mirror.stream.centos.org/9-stream/BaseOS/x86_64/os/repodata/a37577dc74011c2870ad2469ceda42a2c1c27cd6a7bced18255b4706d4461e2b-comps-BaseOS.x86_64.xml 
…
15:37:28: cr_download: Successfully downloaded: /tmp/createrepo_c_tmp_repo_QHITzu/repodata/a37577dc74011c2870ad2469ceda42a2c1c27cd6a7bced18255b4706d4461e2b-comps-BaseOS.x86_64.xml
…
type group added to list from path: /tmp/createrepo_c_tmp_repo_QHITzu/repodata/a37577dc74011c2870ad2469ceda42a2c1c27cd6a7bced18255b4706d4461e2b-comps-BaseOS.x86_64.xml 
…

It loads all necessary ones, yes. But then:

15:37:28: Using groupfile: tmp/.repodata/a37577dc74011c2870ad2469ceda42a2c1c27cd6a7bced18255b4706d4461e2b-comps-BaseOS.x86_64.xml

And then never merges it with AppStream.


Also note that --nogroup is well-documented option… That's not implemented at all (I mean, it works by default :trollface:).

@Conan-Kudo
Copy link
Member

@kontura could you please take a look at this?

@kontura
Copy link
Contributor

kontura commented Jan 24, 2022

I am not sure we are going to be able to fix this any time soon.

We would have to add a new dependency on something like libcomps (which I don't think we want) and even still I believe there isn't any defined way how groups should be merged (how to merge two repos if both contain definitions for the same group name with different content).
DNF has this problem as well and it prioritizes repos by alphabetic order. 🙁

We could definitely fix the documentation to reflect the current state though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants