From 0240ec8ed747ad86eb7c44846a254e10238e90f1 Mon Sep 17 00:00:00 2001 From: Jonathan Yoder Date: Tue, 3 May 2022 08:13:12 -0400 Subject: [PATCH 1/3] '-buildvcs=false' for temporary build fix --- justfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/justfile b/justfile index 01953e1..ea8fbe4 100644 --- a/justfile +++ b/justfile @@ -52,7 +52,7 @@ vet: # Builds Go code natively. build: cd examples && \ - go build -o ../out/ ./... + go build -buildvcs=false -o ../out/ ./... # run linters lint: From cf25920a93acecb59df5f9f1b3cace59e252c8a6 Mon Sep 17 00:00:00 2001 From: Jonathan Yoder Date: Tue, 3 May 2022 08:21:28 -0400 Subject: [PATCH 2/3] Update GHA to Go 1.18; add 'bash' justfile target --- .github/workflows/github-actions-ci.yml | 2 +- justfile | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/github-actions-ci.yml b/.github/workflows/github-actions-ci.yml index 5cf1bd9..b9a976c 100644 --- a/.github/workflows/github-actions-ci.yml +++ b/.github/workflows/github-actions-ci.yml @@ -9,7 +9,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: 1.17 + go-version: 1.18 - name: Checkout code uses: actions/checkout@v2 diff --git a/justfile b/justfile index ea8fbe4..b54deed 100644 --- a/justfile +++ b/justfile @@ -60,6 +60,14 @@ lint: ./scripts/header-check.sh ./scripts/test-wiring.sh +# Opens a shell in the dev docker container. +bash: + docker run {{ interactive }} --rm \ + -v {{justfile_directory()}}/:/build \ + -e GOCACHE=/platform-lib/.go-cache \ + -w /build \ + rstudio/platform-lib:lib-build /bin/bash + # Builds Go code using docker. Useful when using a MacOS or Windows native IDE. First, # run `just build-build-env' to create the docker image you'll need. build-docker: From 566f47831ea32dd6e2c22f2cf8b98a0bce74fb65 Mon Sep 17 00:00:00 2001 From: Jonathan Yoder Date: Tue, 3 May 2022 09:03:29 -0400 Subject: [PATCH 3/3] Use '-buildvcs=false' in test.sh --- scripts/test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/test.sh b/scripts/test.sh index 4454a05..b7af5f2 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -11,7 +11,7 @@ DEF_TEST_ARGS=${DEF_TEST_ARGS:--short} for MODULE in ${MODULES}; do cd ${MODULE} - go test ${DEF_TEST_ARGS} ${TEST_ARGS[*]} + go test -buildvcs=false ${DEF_TEST_ARGS} ${TEST_ARGS[*]} result=$? if [[ $result -ne 0 ]]; then __EXITCODE=$result