fix(options): Preserve Only and Except Options #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems correct, but we need a test that fails on HEAD currently, please. |
| @@ -28,6 +28,15 @@ def merge(new_opts) | |||
| else | |||
| @opts_hash.merge(new_opts) | |||
| end | |||
|
|
|||
| unless opts_hash[:only].nil? || opts_hash[:only].empty? | |||
There was a problem hiding this comment.
I think you want opts_hash.key?(:only) || ... or assign it to a variable and then check, otherwise you're searching through the hash twice.
|
Thanks for your contribution! @dblock please hold it open for a while, i want to dig it deeper. |
|
@dblock I made the change that you pointed out. As far as the test goes, I honestly wouldn't know how to write it for this. |
|
I'll leave this to @marshall-lee. @Linell without this fix something breaks in your code, right? Write a test that reproduces the broken behavior without this change. |
Don't override `options[:only]` and `options[:except]` when merging in new options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't override
options[:only]andoptions[:except]when merging in new options.Resolves #181