Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Launchable into mingw #11043

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Integrate Launchable into mingw #11043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5e6077
Integrate Launchable into mingw
ono-max Jun 22, 2024
7922681
Use $GITHUB_PATH
ono-max Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/launchable/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ runs:
working-directory: ${{ inputs.srcdir }}
run: |
set -x
PATH=$PATH:$(python -msite --user-base)/bin
echo "PATH=$PATH" >> $GITHUB_ENV
echo "$(python -msite --user-base)/bin" >> $GITHUB_PATH
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent this step from replacing all backslashes with forward slashes, $GITHUB_PATH is used. Based on my investigation, it seems to be that all paths are expressed as Unix path style when referring them in Bash.

https://github.com/ruby/ruby/actions/runs/9626581444/job/26576319914?pr=11043#step:10:271

pip install --user launchable
launchable verify || true
: # The build name cannot include a slash, so we replace the string here.
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/mingw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ jobs:
srcdir: src
builddir: build
makeup: true
# Set fetch-depth: 10 so that Launchable can receive commits information.
fetch-depth: 10

- name: configure
run: >
Expand All @@ -120,6 +122,18 @@ jobs:
- name: make install
run: make DESTDIR=../install install-nodoc

- name: Set up Launchable
uses: ./.github/actions/launchable/setup
with:
os: windows-2022
# If we support new test task, we need to change this test-opts.
test-opts: --retry --job-status=normal --show-skip --timeout-scale=1.5
${{ matrix.test-all-opts }}
launchable-token: ${{ secrets.LAUNCHABLE_TOKEN }}
builddir: build
srcdir: src
continue-on-error: true

- name: test
timeout-minutes: 30
run: make test
Expand All @@ -138,6 +152,7 @@ jobs:
RUBY_TESTOPTS: >-
--retry --job-status=normal --show-skip --timeout-scale=1.5
${{ matrix.test-all-opts }}
${{ env.TESTS }}
BUNDLER_VERSION:
if: ${{ matrix.test_task == 'check' || matrix.test_task == 'test-all' || StartsWith(matrix.test_task, 'test/') }}

Expand Down
Loading