Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include repo name in merge commit message? #185

Open
RalfJung opened this issue Nov 6, 2022 · 0 comments
Open

Include repo name in merge commit message? #185

RalfJung opened this issue Nov 6, 2022 · 0 comments

Comments

@RalfJung
Copy link
Member

RalfJung commented Nov 6, 2022

Both Clippy and Miri use some sort of tooling to reflect their own local history into the rustc repo, preserving individual commits. This unfortunately means that when bors creates a Miri merge commit like "Auto merge of #2636 - RalfJung:scalar-field-retag, r=oli-obk", when that commit gets put into the rustc repo, Github interprets #2636 as a rustc PR number, which of course leads to bogus links.

Would it be possible for bors to create these commit messages in a way that the links will keep working when the message is put into a different repo, at least within the rust-lang org?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant