New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow try-builds to be rolled up #189

Open

compiler-errors opened this issue Feb 3, 2023 · 1 comment

Member

compiler-errors commented Feb 3, 2023

Pending try builds have their checkboxes unchecked, even though the code suggests they should be disabled:

homu/homu/html/queue.html

Lines 180 to 184 in c8f51b8

    
           {% set checkbox_state = 
        
               ('checked' if state.prechecked else '') if 
        
                   ((state.status == 'approved' or (state.status == 'pending' and not state.try_)) and state.rollup != 'never') 
        
               else 'disabled' 
        
           %}

I can see someone accidentally rolling up a try build because of this 😰

Member Author

compiler-errors commented Feb 3, 2023

state.status == 'pending' and not state.try_ should be False :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment