Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang agenda generator ignores lang-nominated closed issues #199

Open
pnkfelix opened this issue Feb 9, 2023 · 4 comments
Open

lang agenda generator ignores lang-nominated closed issues #199

pnkfelix opened this issue Feb 9, 2023 · 4 comments
Labels

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Feb 9, 2023

If someone tags a closed issue (specifically, a merged PR) as I-lang-nominated, it does not get picked up by our current meeting agenda generator.

See for example: rust-lang/rust#106323

@apiraino
Copy link

apiraino commented Feb 9, 2023

Relevant code in the lang agenda generator of the triagebot

@joshtriplett
Copy link
Member

I had the impression this was intentional (so that we could close issues without having to un-nominate them), but no objection to changing it if folks want to bring closed things to our attention.

@joshtriplett
Copy link
Member

We seem to have a rough consensus in favor of doing this; let's go ahead and make this change to the agenda generator.

@apiraino
Copy link

Note: removing that flag will pull any old I-lang-nominated (likely already discussed) from these repositories:

("rust-lang", "rfcs"),
("rust-lang", "rust"),
("rust-lang", "reference"),
("rust-lang", "lang-team"),
("rust-lang", "compiler-team")

so probably a cleanup of I-lang-nominated from old issues will help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants