Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The inlayHints_lifetimeElisionHints_useParameterNames config doesn't get passed to the server config struct #11778

Closed
Veykril opened this issue Mar 21, 2022 · 1 comment · Fixed by #11789
Labels
A-config configuration C-bug Category: bug E-easy E-has-instructions Issue has some instructions and pointers to code to get started

Comments

@Veykril
Copy link
Member

Veykril commented Mar 21, 2022

The inlayHints_lifetimeElisionHints_useParameterNames config doesn't get passed to the server config struct, presumably because we also use inlayHints_lifetimeElisionHints which takes priority over the namespace?

@Veykril Veykril added C-bug Category: bug A-config configuration labels Mar 21, 2022
@Veykril
Copy link
Member Author

Veykril commented Mar 21, 2022

Right so this was just a mistake on my part, we obviously can't use fields on inlayHints_lifetimeElisionHints since that is already set to a string, so we should rename inlayHints_lifetimeElisionHints to inlayHints_lifetimeElisionHints_mode or something similar.

Rename needs to happen here https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/rust-analyzer/src/config.rs#L262, then just run cargo test -p rust-analyzer to have the tests output the vscode package.json.

@Veykril Veykril added E-easy E-has-instructions Issue has some instructions and pointers to code to get started labels Mar 21, 2022
@bors bors bot closed this as completed in f1dbc2a Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config configuration C-bug Category: bug E-easy E-has-instructions Issue has some instructions and pointers to code to get started
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant