Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint request: unnecessary extern crate #3513

Closed
Zaechus opened this issue Dec 8, 2018 · 4 comments
Closed

lint request: unnecessary extern crate #3513

Zaechus opened this issue Dec 8, 2018 · 4 comments

Comments

@Zaechus
Copy link
Contributor

Zaechus commented Dec 8, 2018

With the release of Rust 2018, many uses of extern crate are useless. Could there be a lint to recommend removing these occurrences?

@sondr3
Copy link

sondr3 commented Dec 11, 2018

Isn't this something that cargo fix should take care of?

@Zaechus
Copy link
Contributor Author

Zaechus commented Dec 11, 2018

@sondr3 , I agree. This would be an easy cargo fix lint.

@mati865
Copy link
Contributor

mati865 commented Dec 11, 2018

Rustfix already does it but it's buggy.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 11, 2018

The compiler already has the rust_2018_idioms lint group. You can try if that already solves most of what you want. If not, please open an issue for concrete problems against rustc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants