Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require macro and generic testcases for new lints and lint updates #3982

Open
gnzlbg opened this issue Apr 17, 2019 · 1 comment
Open

require macro and generic testcases for new lints and lint updates #3982

gnzlbg opened this issue Apr 17, 2019 · 1 comment
Labels
T-macros Type: Issues with macros and macro expansion

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 17, 2019

Given how many lints are currently broken for code inside macros, and how many lints have been so over the years, I think it should be a requirement for new lints to at least contain one test that tries to break the lint when used inside a macro. I believe most issues could have been caught by just remembering that macros exists when testing a new lint.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Apr 17, 2019

I also believe that the same applies to generics.

Also, I am not suggesting that new lints or updated lints should "work" on macros or generics. The only thing that I am suggesting is that if they cannot work in these contexts, they should try to detect these and bail out silently instead of displaying false positives.

@gnzlbg gnzlbg changed the title require macro testcases for new lints and lints updated require macro and generic testcases for new lints and lint updates Apr 17, 2019
@phansch phansch added the T-macros Type: Issues with macros and macro expansion label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-macros Type: Issues with macros and macro expansion
Projects
None yet
Development

No branches or pull requests

2 participants