From 90b361b3a748e9fb01cd9aec7b83edca2d9e996e Mon Sep 17 00:00:00 2001 From: Michael Lamparski Date: Wed, 18 Apr 2018 16:48:34 -0400 Subject: [PATCH] fix my unit test that was horrendously wrong and add one for non-mut slicing since I touched that method too --- src/liballoc/tests/str.rs | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/liballoc/tests/str.rs b/src/liballoc/tests/str.rs index e3f198f736232..a03b61ec97e51 100644 --- a/src/liballoc/tests/str.rs +++ b/src/liballoc/tests/str.rs @@ -401,12 +401,26 @@ fn test_str_get_maxinclusive() { } } +#[test] +fn test_str_slice_rangetoinclusive_ok() { + let s = "abcαβγ"; + assert_eq!(&s[..=2], "abc"); + assert_eq!(&s[..=4], "abcα"); +} + +#[test] +#[should_panic] +fn test_str_slice_rangetoinclusive_notok() { + let s = "abcαβγ"; + &s[..=3]; +} + #[test] fn test_str_slicemut_rangetoinclusive_ok() { let mut s = "abcαβγ".to_owned(); let s: &mut str = &mut s; - &mut s[..=3]; // before alpha - &mut s[..=5]; // after alpha + assert_eq!(&mut s[..=2], "abc"); + assert_eq!(&mut s[..=4], "abcα"); } #[test] @@ -414,7 +428,7 @@ fn test_str_slicemut_rangetoinclusive_ok() { fn test_str_slicemut_rangetoinclusive_notok() { let mut s = "abcαβγ".to_owned(); let s: &mut str = &mut s; - &mut s[..=4]; // middle of alpha, which is 2 bytes long + &mut s[..=3]; } #[test]