Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tidy check to prevent from adding a new test to src/test #106724

Closed
JohnTitor opened this issue Jan 11, 2023 · 4 comments · Fixed by #106734
Closed

Add a tidy check to prevent from adding a new test to src/test #106724

JohnTitor opened this issue Jan 11, 2023 · 4 comments · Fixed by #106734
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@JohnTitor
Copy link
Member

JohnTitor commented Jan 11, 2023

The diff is huge and I cannot check on web UI, but is there a tidy check that prevents contributors from adding a test to src/test?
A PR modifying an existing test now has a merge conflict e.g. #106167 but a PR adding a new test doesn't e.g. #106660, and I'm worried if a new test is added to src/test by accident.

Originally posted by @JohnTitor in #106458 (comment)

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc E-help-wanted Call for participation: Help is requested to fix this issue. labels Jan 11, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 11, 2023

Mentoring instructions: Add a new module to src/tools/tidy, then call the check from

// Checks that need to be done for both the compiler and std libraries.
. See the surrounding code for examples of how tidy checks work.

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 11, 2023

I am confused as to why this was not a blocker for moving the tests

@jyn514
Copy link
Member

jyn514 commented Jan 11, 2023

@BoxyUwU "I didn't think of it"

@albertlarsan68
Copy link
Member

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants