Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test folder contains too many test cases #42770

Closed
earthengine opened this issue Jun 20, 2017 · 4 comments
Closed

Some test folder contains too many test cases #42770

earthengine opened this issue Jun 20, 2017 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@earthengine
Copy link

earthengine commented Jun 20, 2017

As a folder is a minimal unit of test case sets, it might takes too long to finish test if there are too many files and we want to add a single test into that folder and test for the new folder.

For example, src/test/run-pass contains 2500+ tests and took almost 20 mins to run through.

Test cases should be organised better and so we don't take too long to add a new test and verify a minimal set that includes the new test.

@Mark-Simulacrum Mark-Simulacrum added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jun 20, 2017
@sanxiyn
Copy link
Member

sanxiyn commented Jun 20, 2017

See #20796 for the previous discussion.

@durka
Copy link
Contributor

durka commented Jun 22, 2017

Is it useful to consider a folder as a "minimal unit" of tests? I'm not sure. Where did you see that suggestion? You can run a single test: e.g. ./x.py test --stage 1 src/test/run-pass --test-args name_of_test.rs.

@Mark-Simulacrum
Copy link
Member

I don't really see it as feasible for us to split up tests (indeed, I've wanted more tests in the same folder but different categories before to make it easier to write and move them).

@Mark-Simulacrum
Copy link
Member

I'm going to close this. I don't think we're moving to split test cases into folders, much, though I imagine a PR which grouped up test cases would maybe be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

4 participants