Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #![feature(nll)] to supplement -Znll #46716

Closed
nikomatsakis opened this issue Dec 13, 2017 · 5 comments
Closed

add #![feature(nll)] to supplement -Znll #46716

nikomatsakis opened this issue Dec 13, 2017 · 5 comments
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@nikomatsakis
Copy link
Contributor

As part of the NLL development, the plan is to allow people on nightly to "opt-in" to the new checker. My plan is to allow one of two things. Either you can use the -Znll compilation flag (as we do today) or you can use #![feature(nll)] in your code.

I think it should work like this:

  • -Znll implies -Zborrowck=mir. This is not true today and requires a small amount of tweaking.
  • #![feature(nll)] implies -Znll.
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-compiler-nll labels Dec 13, 2017
@nikomatsakis nikomatsakis added this to the NLL prototype milestone Dec 13, 2017
@pnkfelix
Copy link
Member

(-Z nll should also imply -Z two-phase-borrows; that is, #46537 is part of the game plan here.)

@spastorino
Copy link
Member

I'm working on this task, it's almost done. Just some things are taking ages because of compile times :(.

@pnkfelix
Copy link
Member

This is probably resolved by #46862 (though I think we still want to have #![feature(nll)] imply -Z two-phase-borrows, and I don't think that PR included that).

@spastorino
Copy link
Member

@pnkfelix it is included, it's this commit 2019d69

@pnkfelix
Copy link
Member

ah great, then I'm closing this as finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants