Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating LLVM version #58335

Closed
Disasm opened this issue Feb 9, 2019 · 6 comments
Closed

Updating LLVM version #58335

Disasm opened this issue Feb 9, 2019 · 6 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Disasm
Copy link
Contributor

Disasm commented Feb 9, 2019

I'd like to add tier2 platforms for RV64IMAC and RV64GC targets. However, simple target implementation cannot be built against current rustc/8.0-2019-01-16 LLVM version. We need to get some LLVM patches for RV64 from upstream (which are already there). At the moment I have no idea how to achieve this. Hypothetical choices are:

  • Cherry-pick only the necessary patches into Rust LLVM tree
  • Determine some point in upstream LLVM which contains all needed patches and merge it into Rust LLVM tree
  • Rebase Rust LLVM tree to the point mentioned above

I will experiment with different choices, but I need to know which approach is actually used and what should I do next.

@jonas-schievink jonas-schievink added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2019
@davidlt
Copy link

davidlt commented Feb 10, 2019

Maybe Alex @asb could provide a good suggestion. He also provided an update on RISC-V support in LLVM at FOSDEM 2019: https://fosdem.org/2019/schedule/event/riscvllvmclang/

@nikic
Copy link
Contributor

nikic commented Feb 10, 2019

This depends on how many patches we're talking. If it's just two or three, they can be cherry-picked (you can submit a PR at https://github.com/rust-lang/llvm-project). If a lot of changes are necessary, then the Rust LLVM fork will have to be rebased.

@Disasm
Copy link
Contributor Author

Disasm commented Feb 10, 2019

@nikic At the moment I can build RV64 support with 16 patches, but I can try to reduce this patch set. Theoretical minimum is 4 patches, but I haven't tried this yet.

@michaelwoerister
Copy link
Member

Can we update to LLVM 8 proper? The rc2 for that is already out.

@nikic
Copy link
Contributor

nikic commented Feb 12, 2019

We are already on LLVM 8. These changes are part of LLVM 9.

@michaelwoerister
Copy link
Member

Ah, OK. I hope we stay on LLVM 8 until the next beta branches off.

@Disasm Disasm closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants