Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type inference regression #67610

Closed
Mark-Simulacrum opened this issue Dec 25, 2019 · 1 comment
Closed

type inference regression #67610

Mark-Simulacrum opened this issue Dec 25, 2019 · 1 comment
Labels
A-inference Area: Type inference regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

I usually deem these as not too interesting but this one felt a bit out of the norm -- it looks like &Foo.to_string_lossy() used to (deref?) coerce to &str but not sure. I think it's fine to just close this if we don't want to do deeper investigation here.

cc @varkor
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 25, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Dec 25, 2019
Closed
@jonas-schievink jonas-schievink added the A-inference Area: Type inference label Dec 25, 2019
@varkor
Copy link
Member

varkor commented Dec 28, 2019 •
edited
Loading

I think this was observed in #64856 (comment) and it was agreed in FCP to accept this regression: #64856 (comment). Thanks for noting it, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-inference Area: Type inference regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas-schievink @varkor @Mark-Simulacrum