Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider printing the query stack on ICE, even without RUST_BACKTRACE. #70287

Open
eddyb opened this issue Mar 22, 2020 · 0 comments
Open

Consider printing the query stack on ICE, even without RUST_BACKTRACE. #70287

eddyb opened this issue Mar 22, 2020 · 0 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Mar 22, 2020

It's valuable information, including to the user, since it may point to a very specific part of the code (before they even report the ICE to us), and it's always available (even without debuginfo).

We could even print the query stack like a set of diagnostic messages, highlighting the span that was provided with tcx.at(span) (if any) - I guess we have the code for it, for query cycles?

cc @rust-lang/compiler
@Centril Centril added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @Centril