Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#71819 Broke windows bootstrap. #72057

Closed
crlf0710 opened this issue May 9, 2020 · 1 comment
Closed

#71819 Broke windows bootstrap. #72057

crlf0710 opened this issue May 9, 2020 · 1 comment
Labels
C-bug Category: This is a bug.

Comments

@crlf0710
Copy link
Member

crlf0710 commented May 9, 2020

In #71819, this code is added in bootstrap.py

    required = not sys.platform == 'win32'
    ostype = require(["uname", "-s"], exit=required).decode(default_encoding)
    cputype = require(['uname', '-m'], exit=required).decode(default_encoding)

And on windows, this error is emitted:

  File "L:\ThirdParty\rust\rust-workdir\src\bootstrap\bootstrap.py", line 184, in default_build_triple
    ostype = require(["uname", "-s"], exit=required).decode(default_encoding)
AttributeError: 'NoneType' object has no attribute 'decode'

@jyn514 cc @Mark-Simulacrum

@crlf0710 crlf0710 added the C-bug Category: This is a bug. label May 9, 2020
@Mark-Simulacrum
Copy link
Member

This is fixed by #71964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants