Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc does not update the stored theme if the currently displayed theme matches the system #78273

Closed
Nemo157 opened this issue Oct 23, 2020 · 2 comments · Fixed by #78293
Closed
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Nemo157
Copy link
Member

Nemo157 commented Oct 23, 2020

Repro:

This affects the plan we have for docs.rs to follow rustdoc's theme setting, rust-lang/docs.rs#1116 (comment), I assumed that rustdoc would update the stored theme whenever it changes so we could synchronize off that. Missing the initial setting based on the fact that light is the "default" theme loaded before the JS runs seems like a bug.

cc @nasso,

@Nemo157 Nemo157 added the C-bug Category: This is a bug. label Oct 23, 2020
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2020

Error: Label rustdoc-ui can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbot rustbot added A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 23, 2020
@jyn514 jyn514 added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Oct 23, 2020
@nasso
Copy link
Contributor

nasso commented Oct 23, 2020

I assumed that rustdoc would update the stored theme whenever it changes so we could synchronize off that.

I'll implement this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants