Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustc-ap-rustc_target to dependencies #2658

Closed
topecongiro opened this issue Apr 28, 2018 · 0 comments
Closed

Add rustc-ap-rustc_target to dependencies #2658

topecongiro opened this issue Apr 28, 2018 · 0 comments
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@topecongiro
Copy link
Contributor

Recently abi module was remove from libsyntax and moved to librustc_target (cc rust-lang/rust#50228). In order to catch up with the change, we need to:

  1. Update rustc-ap_syntax and add rustc-ap-rustc_target to depenencies.
  2. Replace syntax::abi with rustc_target::spec::abi.
  3. Fix broken code, if available.
@topecongiro topecongiro added the good first issue Issues up for grabs, also good candidates for new rustfmt contributors label Apr 28, 2018
@rleungx rleungx mentioned this issue Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@topecongiro