Memory Leak occurs when GraphicsOutput::query_mode is called.

[JarlEvanson]

A memory leak occurs when GraphicsOutput::query_mode is called. The UEFI specification specifies that the GraphicsOutputModeInformation is returned in a callee-allocated buffer, but GraphicsOutput::query_mode does not free the buffer.

[phip1611]

Good catch!

For reference: https://uefi.org/specs/UEFI/2.10/12_Protocols_Console_Support.html#efi-graphics-output-protocol-querymode

[phip1611]

Hm, I don't see how we can easily fix this without having access to the boot services. Probably, this is the point where we should consider #905, i.e., having the boot services stored in a global static.

What do you think, @nicholasbishop ?

I've set up a PR that comes with a breaking change:
#969

@JarlEvanson Did you spot this by looking at the code or by with some nice debugging tooling? I'm curious

[JarlEvanson]

I was looking at the specification and noticed that it returned a callee allocated buffer, but the uefi-rs implementation didn't take BootServices to deallocate it.

[nicholasbishop]

Should be fixed now with Philipp's PR merged. Thanks again for filing this issue :)

Re comment 3, added a note about this to #893 (the "add a global table pointer" issue).