Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run Clippy for all backends, rework the rustdoc job #477

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Jun 12, 2024

Consolidates Clippy runs into one job which uses fixed Nightly version. Moves Clippy, rustdoc, and rustfmt jobs into a separate workflow file.

Additionally, tweaks the rustdoc job to use only rustdoc with -Dwarnings flag. Minimal versions job has nothing to do with docs and should be done separately for each target. cargo deadlinks was not used to check external links and internal links are checked by rustdoc.

Closes #446

@newpavlov newpavlov marked this pull request as ready for review June 12, 2024 13:08
@newpavlov newpavlov requested a review from josephlr June 12, 2024 13:08
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, just a few minor nits.

.github/workflows/workspace.yml Outdated Show resolved Hide resolved
.github/workflows/workspace.yml Outdated Show resolved Hide resolved
.github/workflows/workspace.yml Outdated Show resolved Hide resolved
.github/workflows/workspace.yml Outdated Show resolved Hide resolved
.github/workflows/workspace.yml Show resolved Hide resolved
@newpavlov newpavlov requested a review from josephlr June 14, 2024 13:41
@newpavlov newpavlov changed the title CI: run Clippy in a separate job for several targets CI: run Clippy for all backends, rework the rustdoc job Jun 14, 2024
@newpavlov newpavlov merged commit b7bba16 into master Jun 14, 2024
54 checks passed
@newpavlov newpavlov deleted the clippy branch June 14, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run cargo clippy in CI for all targets
2 participants