Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strategy design pattern #120

Closed
fade2black opened this issue Jan 2, 2021 · 4 comments · Fixed by #146
Closed

Strategy design pattern #120

fade2black opened this issue Jan 2, 2021 · 4 comments · Fixed by #146
Labels
C-addition Category: Adding new content, something that didn't exist in the repository before
Projects
Content

Comments

@fade2black
Copy link
Contributor

Working on https://medium.com/swlh/strategy-design-pattern-in-rust-5f5486cd294c?source=friends_link&sk=6871f4761dc6c4b7c0bc3ccefd22e408
@simonsan simonsan mentioned this issue Jan 2, 2021
Open
57 tasks
@simonsan simonsan added this to In progress in Content Jan 2, 2021
@simonsan simonsan added the C-addition Category: Adding new content, something that didn't exist in the repository before label Jan 2, 2021
@NilSet
Copy link

NilSet commented Jan 3, 2021

The blog post uses dynamic dispatch without any apparent need. The article in the book should probably cover the tradeoffs of using generics vs using dynamic dispatch.

@fade2black
Copy link
Contributor Author

@NilSet How about removing it (dispatch version) completely?

@fade2black
Copy link
Contributor Author

@NilSet Here I provide a version with static dispatch.

Content automation moved this from In progress to Done Jan 6, 2021
@simonsan simonsan mentioned this issue Jan 7, 2021
Merged
@simonsan simonsan reopened this Jan 7, 2021
Content automation moved this from Done to In progress Jan 7, 2021
@simonsan
Copy link
Collaborator

simonsan commented Jan 7, 2021

Linked it to the PR, let's keep it open until we actually merge it. Maybe there is still some feedback from @pickfire and I'll also read through it the upcoming days. Cheers.

Content automation moved this from In progress to Done Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-addition Category: Adding new content, something that didn't exist in the repository before
Projects
Content
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strategy fade2black/patterns
3 participants
@fade2black @NilSet @simonsan