Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null for non-existent customer IDs in getCustomerId function #2091

Open
coderabbitai bot opened this issue Aug 22, 2024 · 0 comments
Open

Return null for non-existent customer IDs in getCustomerId function #2091

coderabbitai bot opened this issue Aug 22, 2024 · 0 comments
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Aug 22, 2024

Consider returning null instead of -1 for non-existent customer IDs in the getCustomerId function. Returning -1 may lead to confusion if customerId is expected to be a non-negative number. \n\nFor more details, see the discussion in PR #2037 and the specific comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant