Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released on aur #6

Closed
b-reich opened this issue Apr 4, 2022 · 10 comments
Closed

Released on aur #6

b-reich opened this issue Apr 4, 2022 · 10 comments
Labels
good first issue Good for newcomers

Comments

@b-reich
Copy link
Contributor

b-reich commented Apr 4, 2022

Hi, I start maintaining the the aur for smap.

Can be found here: https://aur.archlinux.org/packages/smap-git
Source can be found here: https://github.com/b-reich/aur

This could be referenz in the readme if you like. (I can open the PR)

@s0md3v s0md3v added the good first issue Good for newcomers label Apr 4, 2022
@s0md3v
Copy link
Owner

s0md3v commented Apr 4, 2022

Thanks for the AUR package @b-reich.

I can add it to the README myself but it would be better if you do it because that will make you a "contributor" in Smap.

@s0md3v s0md3v closed this as completed Apr 4, 2022
@b-reich
Copy link
Contributor Author

b-reich commented Apr 4, 2022

@s0md3v I will create a PR

@b-reich b-reich mentioned this issue Apr 4, 2022
@b-reich
Copy link
Contributor Author

b-reich commented Apr 7, 2022

@s0md3v I can also provide an AUR package which provides the compiled bin.

@s0md3v
Copy link
Owner

s0md3v commented Apr 7, 2022

@b-reich, it will pull the binary from the latest release right?

Let's have two AUR packages then, smap-git for latest stable binary and smap-git-dev for compiling the master branch from source.

@b-reich
Copy link
Contributor Author

b-reich commented Apr 7, 2022

@s0md3v per convention a *-git package always build from source. I will create an smap package which use the latest binary.
This would fit in the name convention.

@b-reich
Copy link
Contributor Author

b-reich commented Apr 7, 2022

@s0md3v https://aur.archlinux.org/packages/smap-bin is online
Which deps are required? nmap?

-binis the correct convention for it

@s0md3v
Copy link
Owner

s0md3v commented Apr 7, 2022

Thanks @b-reich! There are no dependencies.

Btw, why is it smap-bin and not smap?

@b-reich
Copy link
Contributor Author

b-reich commented Apr 7, 2022

@s0md3v I was wrong...
smap should build from tag (0.1.0)
smap-bin uses precompiled bins
smap-git build from master/develop (depends on the git/branch flow)

@s0md3v
Copy link
Owner

s0md3v commented Apr 7, 2022

Hi @b-reich, I went through PKGBUILD file and turns out it has a hardcoded version number.
Shouldn't it fetch the latest version automatically?

@b-reich
Copy link
Contributor Author

b-reich commented Apr 7, 2022

Hi @b-reich, I went through PKGBUILD file and turns out it has a hardcoded version. Shouldn't it fetch the latest version automatically?

Precompiled should updated by hands, the checksum are also updated by hand. I think this is correct in this form. - I have to update every release by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants