Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: miguelgrinberg/python-socketio Loading
base: main
Choose a base ref
...
head repository: saad-ashfaq/python-socketio Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 25, 2023

  1. Handle Redis Sentinel Failover in KombuManager 

    The redis package raises the exception redis.exceptions.ConnectionError
when a failover occurs as shown by the exception stack trace originating
at message = queue.get(block=True) in _listen(). Since the except block
is only handling OSError and kombu.exceptions.KombuError exceptions,
this error is not detected resulting in loop termination. Add
redis.exceptions.ConnectionError to the except block so the exception is
caught and the new master is detected when connecting to the Sentinel
url as the loop is executed again.

Signed-off-by: Saad Ashfaq <saadashfaq17@gmail.com>
    @saad-ashfaq
    saad-ashfaq committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9d64fc4 View commit details
    Browse the repository at this point in the history
Loading