Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend repo null/undefined mega clean up #1214

Open
nguyenaiden opened this issue Aug 2, 2022 · 0 comments
Open

Frontend repo null/undefined mega clean up #1214

nguyenaiden opened this issue Aug 2, 2022 · 0 comments

Comments

@nguyenaiden
Copy link
Contributor

Description: The front end repo currently is running into scalability issues.

  1. The use of undefined and null as absence of value. This causes a ton of headache when trying to develop new features and make changes since we always have to guard against both, and sometimes TSlint does not recognize when a value is already guarded. This leads to a ton of unnecessary nullish coalescence and undefined checks.
  2. Large components with a lot inline defined functions that makes unit testing very difficult. This results in putting a lot of trust and overhead on our e2e testing suite. While e2e testing is good, it should not be the only defacto line of defense against potential regressions. E.g: Swap.ts
  3. Look to migrate data/state management to react query to promote composability, modularity, and testability of the methods.

Note: List is subjected to grow/change as we move forward with this plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant