Skip to content
This repository has been archived by the owner on Mar 30, 2020. It is now read-only.

Mod crash when i turn it on / Not even if CS runs Vanilla #26

Closed
RegensteineR1999 opened this issue May 18, 2018 · 2 comments
Closed

Mod crash when i turn it on / Not even if CS runs Vanilla #26

RegensteineR1999 opened this issue May 18, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@RegensteineR1999
Copy link

RegensteineR1999 commented May 18, 2018

Describe the bug
Get the typical error windows from the game when i turn it on.

A Mod caused an error [System.Exception]

Details:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentException: No target method specified for class Shicho.Patcher.CinematicCameraExtendedPatch
  at Harmony.PatchProcessor.PrepareType () [0x00000] in <filename unknown>:0 
  at Harmony.PatchProcessor..ctor (Harmony.HarmonyInstance instance, System.Type type, Harmony.HarmonyMethod attributes) [0x00000] in <filename unknown>:0 
  at Harmony.HarmonyInstance.<PatchAll>b__7_0 (System.Type type) [0x00000] in <filename unknown>:0 
  at Harmony.CollectionExtensions.Do[Type] (IEnumerable`1 sequence, System.Action`1 action) [0x00000] in <filename unknown>:0 
  at Harmony.HarmonyInstance.PatchAll (System.Reflection.Assembly assembly) [0x00000] in <filename unknown>:0 
  at Shicho.Bootstrapper.Bootstrap () [0x00000] in <filename unknown>:0 
  at Shicho.Mod.Mod.OnEnabled () [0x00000] in <filename unknown>:0 
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception`

A Mod caused an error [System.Exception]

Details:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at Shicho.Mod.Mod.OnSettingsUI (UIHelperBase helper) [0x00000] in <filename unknown>:0 
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception`

Expected behavior
Just that we can find the problem and maybe make you mod better / kill some bugs hm?

Screenshots
https://photos.app.goo.gl/HGORWwRFUxiuofxN2

List of all enabled mods:
Just Shicho

Additional context
Feel free anytime to write me :) My English is just ehh very basic/simple.
(I hope that's enough)
Best regards

@RegensteineR1999 RegensteineR1999 changed the title Mod crash and not work with standalone run in CS Mod crash when i turn it on / Not even if CS runs Vanilla May 18, 2018
@saki7
Copy link
Owner

saki7 commented May 18, 2018

Shicho was expecting Cinematic Camera Extended to exist even if an user had not subscribed to it. (Note: this was originally an intended behavior because Shicho's built for streamers)

This has been fixed in commit b5a0897 which introduced the line:

https://github.com/SETNAHQ/Shicho/blob/cc3891c1c65a0a36c7aaa918e5201205bd50afe1/Shicho/Patcher/CinematicCameraExtendedPatch.cs#L25

Thanks for the report. Workshop content will be updated soon.

@saki7 saki7 closed this as completed May 18, 2018
@saki7
Copy link
Owner

saki7 commented May 18, 2018

@RegensteineR1999 I just updated the workshop content. You can restart your Steam client to get immediate updates. If you're still seeing the error, please reopen the issue.

p.s. I've edited your comment to fix the formatting problem

@saki7 saki7 self-assigned this May 18, 2018
@saki7 saki7 added the bug Something isn't working label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants