-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10355 - Template Parser for extended modules #10356
base: hotfix
Are you sure you want to change the base?
Conversation
Hey @ojs87, thanks a lot for contributing to the project! Regards, |
Hey @ojs87 ! I've given this a test locally and this does appear to resolve the issue when sending via the Workflow-Send Email action. However, I see that the issue is still present when sending an Email via the regular Email->Compose action. For example If possible, could you investigate and resolve this aspect too? Thanks! |
Hi @johnM2401, Thanks for testing that, I think this needs to be put on hold for now. This won't work for a Cases email template since the beanList value for cases is aCase and the table_name is case, so a little bit more thought is needed here. Template parsing may need looked at so that the Compose view uses the same parser as the Workflow send Email action. This is not ready to merge as it stands! Thanks, |
Description
Modules that are extended in the custom folder, e.g. AOS_Quotes.php, are not correctly replacing variables based on the variables available in the Email Templates module. This is due to an extended module using a different beanList name(e.g. customAOS_Quotes) and the template parser using that beanList name as the key for the variables.
Motivation and Context
Extended modules should use the same basic variables in the Email Template editor to parse Email Templates
How To Test This
Types of changes
Final checklist