Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #6254 - View Change log produces following error in log: [FATAL… #6416

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from
Open

fixed #6254 - View Change log produces following error in log: [FATAL… #6416

wants to merge 1 commit into from

Conversation

cameronblaikie
Copy link
Contributor

@cameronblaikie cameronblaikie commented Oct 12, 2018 •
edited
Loading

…] SugarBean::populateDefaultValues $field_defs should be an array

Description

added new condition that excludes the audit module because the audit module doesn't have any var-defs

Motivation and Context

#6254

How To Test This

  1. Go to accounts module
  2. Pick view change log action
  3. Check SuiteCRM log

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

Dillon-Brown
Dillon-Brown reviewed Oct 18, 2018
View reviewed changes
data/SugarBean.php Outdated Show resolved Hide resolved
@willrennie willrennie added the Status:Requires Updates Issues & PRs which requires input or update from the author label Mar 29, 2019
@willrennie
Copy link
Contributor

@cameronblaikie please see @Dillon-Brown comments

@cameronblaikie cameronblaikie changed the base branch from hotfix to hotfix-7.10.x June 14, 2019 13:42
@Dillon-Brown Dillon-Brown removed the Status:Requires Updates Issues & PRs which requires input or update from the author label Sep 13, 2019
@Mac-Rae
Copy link
Contributor

Mac-Rae commented Sep 16, 2019

Assessed 👍 Pending Travis

@Mac-Rae Mac-Rae added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Sep 16, 2019
@connorshea connorshea mentioned this pull request Sep 27, 2019
Open
Dillon-Brown
Dillon-Brown suggested changes Oct 8, 2019
View reviewed changes
data/SugarBean.php Outdated Show resolved Hide resolved
@code-ph0y code-ph0y added the Status:Requires Updates Issues & PRs which requires input or update from the author label Jun 5, 2020
@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mattlorimer mattlorimer force-pushed the hotfix-7.10.x branch 2 times, most recently from 3149dea to ab954a4 Compare October 28, 2020 17:49
@jack7anderson7 jack7anderson7 removed the Status:Requires Updates Issues & PRs which requires input or update from the author label Apr 8, 2021
jack7anderson7
jack7anderson7 previously approved these changes Apr 8, 2021
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dillon-Brown Dillon-Brown Dillon-Brown approved these changes

@jack7anderson7 jack7anderson7 jack7anderson7 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cameronblaikie @willrennie @Mac-Rae @SuiteBot @Dillon-Brown @jack7anderson7 @code-ph0y