Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index.d.ts to this repository #146

Closed
sgronblo opened this issue Dec 25, 2017 · 1 comment
Closed

Add index.d.ts to this repository #146

sgronblo opened this issue Dec 25, 2017 · 1 comment

Comments

@sgronblo
Copy link
Contributor

Would you be interested in trying to incorporate the index.d.ts for @types/node-pg-migrate into this repository? This would have at least the following benefits:

  1. It would be easier to keep the index.d.ts in sync with the code. Since older version of this package could have their own older version of index.d.ts
  2. It would be easier to contribute updates to index.d.ts compared to the quite complicated workflow of going through DefinitelyTyped
@dolezel
Copy link
Contributor

dolezel commented Dec 27, 2017 •
edited
Loading

👍 I would appreciate if you can add it.
I will then learn more about typescript and will keep it in sync :)

@sgronblo sgronblo mentioned this issue Jan 4, 2018
Merged
@dolezel dolezel closed this as completed Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgronblo @dolezel