Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate a sandbox having or being run with debug options #2816

Closed
bastik-1001 opened this issue Apr 12, 2023 · 2 comments
Closed

Indicate a sandbox having or being run with debug options #2816

bastik-1001 opened this issue Apr 12, 2023 · 2 comments
Labels
Feature request New feature or idea more info needed More information is needed to move forward

Comments

@bastik-1001
Copy link
Contributor

Is your feature request related to a problem or use case?

It is possible to run some box or boxes with debug options for testing-purposes, then forget that those are set and run programs with potentially unsafe debug options, by accident.

Describe the solution you'd like

SandMan has a status column, where you can add the word DEBUG, whenever a box has any debug option set. This might not even be a string exposed for translation, as I am guessing anyone messing with the debug options to be able to read the documentation and therefore being able to understand it. (I could be wrong, as they might just use a translation tool. Though they still should know what they are doing.)

If you feel fancy, you can add an entry to the log. "$boxname has been initialized with debug options $debugname" or something like that. (While still assuming, those entries not to be seen by that many people, maybe that line should be exposed for translation.)

Describe alternatives you've considered

No response

@bastik-1001 bastik-1001 added the Feature request New feature or idea label Apr 12, 2023
@DavidXanatos
Copy link
Member

we already have somethign liek this,
try adding UnrestrictedToken=y to a box, the icon should become maganta and the status column should say "NOT SECURE"
see

bool CSandBoxPlus::CheckUnsecureConfig() const

what other options should we worn the user about?

@DavidXanatos DavidXanatos added the more info needed More information is needed to move forward label Apr 15, 2023
@bastik-1001
Copy link
Contributor Author

This issue might be obsolete, since there is a warning for unsafe options.

The main idea, was to indicate that any debug option has been set and is enabled for a box, without the need to think if the option itself is risky. Letting it up to the user to decide, since they need to know what they are doing. My assumption was, that warning per option could be overkill, and required that every option needed to be checked against. I am not sure, if my intended approach would have been easier.

If unsafe options are accounted for, and there is no need to indicate that any debug option has been set, then we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or idea more info needed More information is needed to move forward
Projects
None yet
Development

No branches or pull requests

2 participants